Just the confirmation I wanted. So when the PPPoE user authenticates the don't get the hotspot login in page right?
Right, PPPoE users have no idea there is a hotspot. At least the way we set it up, which is we give the router a loopback address and use that for the local address in the PPPoE profile. We also may create a bridge, even if there is only one physical interface in it, and run the hotspot/pppoe server on the bridge. This generally makes it easier if you want to change the port or add/remove ports, as you only have to change the bridge, instead of hotspot/pppoe/dhcp etc.
The PPPoE is also typically using its own pool of IP addresses. Other configurations may or may not work in this way.
(Edited: sometimes we don't create a bridge and run separate PPPoE and/or hotspot servers on each port for isolation reasons. The PPPoE servers can usually share the same IP pool.)